Hi Mattias,
i have tested the update in a DPM installation and we have checked that when enabling gridftp redirection the server just simply crashes. Then we have found out that in order to built the dpm-dsi with the new version of gridftp we had to make some code changes on our dsi , which i don't see in your commits. So it looks strange to us that you could built without touching the code. Could you please confirm that you haven't touched the code? i think we need to release by ourself the new version with the code changes cause we cannot go in production with this release
When you say "in order to build the dpm-dsi with the new version of gridftp we had to make some code changes" does it mean that you had to make changes to make it compile, or it compiles without changes but changes are needed to make it work correctly?
i really don't understand why the build is working in your case..cause our build in jenkins was failing with :
DEBUG: In file included from /builddir/build/BUILD/dpm-dsi-1.9.6/src/dmlite_gridftp.c:10:
DEBUG: /builddir/build/BUILD/dpm-dsi-1.9.6/include/globus_gfs_internal_hack.h:276: error: expected specifier-qualifier-list before 'globus_l_gfs_storattr_t'
DEBUG: /builddir/build/BUILD/dpm-dsi-1.9.6/src/dmlite_gridftp.c: In function 'globus_l_gfs_remote_passive':
DEBUG: /builddir/build/BUILD/dpm-dsi-1.9.6/src/dmlite_gridftp.c:1786: error: 'struct globus_l_gfs_data_operation_s' has no member named 'user_arg
When building packages in koji there is no network available, so the gen_include.sh script - which downloads source rpms using yumdownloader - can not be run. The globus_gfs_internal_hack.h header is therefore not re-generated during the build, but remains the version included in the sources.
thanks a lot Mattias!
actually since we've introduced this way of automatically updating the header some release ago and it's already in production we have been lucky that nothing broke!! I will test the new version once in testing
This update has been submitted for testing by ellert.
This update has been pushed to testing.
Hi Mattias, i have tested the update in a DPM installation and we have checked that when enabling gridftp redirection the server just simply crashes. Then we have found out that in order to built the dpm-dsi with the new version of gridftp we had to make some code changes on our dsi , which i don't see in your commits. So it looks strange to us that you could built without touching the code. Could you please confirm that you haven't touched the code? i think we need to release by ourself the new version with the code changes cause we cannot go in production with this release
Hi!
The root.log lists the correct versions were installed for the build:
The build succeeded without code changes.
To check that it still builds today I just made scratch builds for rawhide and EPEL 6 which both succeeded without ny code changes.
When you say "in order to build the dpm-dsi with the new version of gridftp we had to make some code changes" does it mean that you had to make changes to make it compile, or it compiles without changes but changes are needed to make it work correctly?
i really don't understand why the build is working in your case..cause our build in jenkins was failing with :
which we fixed with https://svnweb.cern.ch/trac/lcgdm/changeset/11887
i can give you more details tomorrow when i will back to work.
ellert edited this update.
New build(s):
Removed build(s):
This update has been submitted for testing by ellert.
When building packages in koji there is no network available, so the gen_include.sh script - which downloads source rpms using yumdownloader - can not be run. The globus_gfs_internal_hack.h header is therefore not re-generated during the build, but remains the version included in the sources.
thanks a lot Mattias! actually since we've introduced this way of automatically updating the header some release ago and it's already in production we have been lucky that nothing broke!! I will test the new version once in testing
This update has been pushed to testing.
This update has reached 14 days in testing and can be pushed to stable now if the maintainer wishes
This update has been submitted for stable by ellert.
This update has been pushed to stable.