Unfortunately seems like there are new problems: gnome-mahjongg will sometimes lag significantly, or freeze completely. One way to induce it is by repeatedly clicking the hint button (20+ times), then start selecting/deselecting tiles until it freezes. Another way is by starting a new game from the game over screen (not from the menu). I will report upstream.
Tested on F38 Xfce
BZ#2187055 gnome-mahjongg will not allow selecting a tile.
Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.
This update has been submitted for testing by kalev.
This update's test gating status has been changed to 'ignored'.
kalev edited this update.
This update has been pushed to testing.
Thanks for the fast response on the PR!
Unfortunately seems like there are new problems: gnome-mahjongg will sometimes lag significantly, or freeze completely. One way to induce it is by repeatedly clicking the hint button (20+ times), then start selecting/deselecting tiles until it freezes. Another way is by starting a new game from the game over screen (not from the menu). I will report upstream.
Tested on F38 Xfce
Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.
Tested on current F38. gnome mahjongg seems to be working correctly. I have not seen the lag reported by @jn64 but my testing is limited so far.
With some additional testing uses the hint-button triggers mentioned by@jn64 I do see some lag.
I filed upstream bug: https://gitlab.gnome.org/GNOME/gnome-mahjongg/-/issues/39
Maybe we can backport the patch for bz#2187055 to 3.38.3 instead?
Sure, fine with me to backport the patch to 3.38.3. Do you want to do a PR for that?
I think I'd give upstream a bit of time first though and see if they can figure out the lagging and freezing issue first.
Thanks, waiting for upstream would be the sensible option, but I'll take the learning opportunity to do this backport :)
Question: Do I make my PR against
rawhidebranch and revert the last 3 commits related to 3.40.0?This update has been unpushed.
Unpushed as per discussion at https://src.fedoraproject.org/rpms/gnome-mahjongg/pull-request/2