Manually tested on F33

Installed on my F28 system, ran a few snaps (classic and strict), all good!

Tested on F29 quickly, works okay.

I tested this by injecting the koji build into my fedora29 base snap build process and it has fixed the issue, nice!

@ngompa: the same data fuels the "snap advise" command that works very well. We should look at how cnf can be integrated with snapd similarly to how it was done in Ubuntu.

The update looks good. I have only one meta-comment, this release supports command-not-found hints and those trigger a dozen new warnings on startup. Most of those are related to /var/cache/snap/commands.db

Same as with F27 I tested a moment before: everything essential works great.

Update and snap installs went without any issues. I tested slack, spotify and a few lesser known snaps. The only issue I found is that slack didn't get the icon initially (it was there when I restarted the app after logging out).

Tested OK on F26

During the install/update I was alarmed by those messages:

skipping the directory /sys
skipping the directory /proc
skipping the directory /dev
skipping the directory /run
skipping the directory /mnt
skipping the directory /var/tmp
skipping the directory /home
skipping the directory /tmp
skipping the directory /dev

Tested on F25 x86_64 with all things working as expected*.

The only exception is slight UI corruption when snap installing software because of older progress bar library but this is a known old issue.

I just tested this on F24 workstation and it works OK.

The only warts are: - need to start the service manually (known issue) - no tab completion (noticed, will be fixed in next upload)

+1

I just tested this on F25 and it worked great out of the box :-) Thanks

I tested this on F24 server and it was good with the following comments:

• there is no preset so the socket is not enabled by default, snap client should be patched to give an useful advice in that case
• the %post command may optionally say something if on f24 (this is how to get started)
• the same comment as for f25 (progress UX corrupted by use of older library)

I'm giving my +1 comment despite the remarks above as this is a big improvement and we can iterate on specific issues.

I installed python0 which is a snap using classic confinement but those obviously don't run. I think that for as long as we don't have an answer for that we should fail in the daemon and return an error message with a link to a tracking bug.

Aha, may I notice that this was on a server variant, not sure if this is relevant.

I started the socket manually, installed hello-world. It has installed correctly although the formatting of the progress bar is incorrect. I suspect we are using an older version of the progress bar package.

Upon installation the snapd.socket was not started. Something is not right with the preset handling.

[zyga@localhost ~]$ systemctl status snapd.socket | cat                         
● snapd.socket - Socket activation for snappy daemon                            
   Loaded: loaded (/usr/lib/systemd/system/snapd.socket; enabled; vendor preset:
 enabled)                                                                       
   Active: inactive (dead)                                                      
   Listen: /run/snapd.socket (Stream)                                           
           /run/snapd-snap.socket (Stream)                                      

So this part was OK but the socket is inactive (dead) any ideas why?

Let's get this released

Let's get this released