Comments

37 Comments

Oops, the formatting has been destroyed there - basically it just changes pmResult to pmdaResult. This has been the definition of this interface for many many years, PCP v7 is just the first release where pmdaResult and pmResult are not always the same.

We think this is a subtle type usage issue in the samba code - I don't have a samba bugzilla account though, could you suggest this patch upstream @abbra and see if it resolves the Fedora build issue?

$ git diff ctdb/utils/pmda/pmda_ctdb.c --- /tmp/git-blob-QUADTU/pmda_ctdb.c 2025-09-04 13:28:32.811115833 +1000 +++ ctdb/utils/pmda/pmda_ctdb.c 2025-09-04 13:27:44.958962334 +1000 @@ -450,7 +450,7 @@ err_out: * instance domain evaluation. / static int -pmda_ctdb_fetch(int numpmid, pmID pmidlist[], pmResult resp, pmdaExt pmda) +pmda_ctdb_fetch(int numpmid, pmID pmidlist[], pmdaResult *resp, pmdaExt pmda) { int ret;

@abbra, thanks for letting us know. I've mentioned it to the primary author of those changes (Ken, in the linked github commit) - hopefully he'll advise shortly on the simplest approach to take (which may be defining -DPMAPI_VERSION=2, but let's wait for Ken on that one).

karma

LGTM

BZ#2363903 SELinux is preventing ps from using the sys_admin capability.
karma

LGTM

From the SE Linux team:

an incorrect path for the rm command in selinux-policy specfile was introduced in the previous build, it is fixed in today's one.

Can you double check @ciupicri ?

@ciupicri this looks like a problem in selinux policy rpm macros, not related to PCP AFAICS.

karma

Thanks!

Thanks for your patience - back from PTO and starting to look into it now.

Yep, done - thanks for the note - not sure why it failed to go through originally.

BZ#1817968 pcp-selinux postinstall scriptlet fails
BZ#1670656 Review Request: grafana - an open source, feature rich metrics dashboard and graph editor
BZ#1670656 Review Request: grafana - an open source, feature rich metrics dashboard and graph editor
BZ#1692995 Review Request: golang-github-macaron-session - Provides the session management of Macaron