Comments

26 Comments

I added the auto push with +1 karma, so it was pushed by the system after imaginaryusername gave it +1.

Works against Electrum 3.3.4

BZ#1662572 Review Request: python-aiohttp-socks - SOCKS proxy connector for aiohttp

Looks like it was caused/discovered by the this commit that I merged into f28 and f29 https://src.fedoraproject.org/rpms/electrum/c/c9d2726896511bd0a047cac6132a96cd25aebdd7?branch=master

qdarkstyle is an optional dependency, but I will create a package for it.

I did not know about these issues before it was pushed to stable

Thanks for your testing and feedback, it makes pushing to stable faster and I am more confident that we did not break anything during update

Fedora 26 still uses the version that runs on Python 2 + one dependency that are only available in Fedora 27 and later

That is true, will see if I am able to extract a patch.

Will make a new update for 3.0.5

3.0.4 was the latest release yesterday. But it looks like they just released 3.0.5. https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

Works for me with certificate signed for the first time (via Ansible that uses acme-tiny under the hood)

Also tested that the acme-tiny will write error to console when it have no write permission to the certificate.

"sni-qt/11398" WARN  12:51:51.237 void StatusNotifierItemFactory::connectToSnw() Invalid interface to SNW_SERVICE 
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/electrum_gui/qt/util.py", line 582, in run
    result = task.task()
  File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/plugin.py", line 141, in get_client
    client = devmgr.client_for_keystore(self, handler, keystore, force_pair)
  File "/usr/lib/python2.7/site-packages/electrum/plugins.py", line 397, in client_for_keystore
    client = self.force_pair_xpub(plugin, handler, info, xpub, derivation, devices)
  File "/usr/lib/python2.7/site-packages/electrum/plugins.py", line 427, in force_pair_xpub
    client_xpub = client.get_xpub(derivation)
  File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/clientbase.py", line 153, in get_xpub
    node = self.get_public_node(address_n, creating).node
  File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/clientbase.py", line 221, in wrapped
    return func(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/clientbase.py", line 198, in get_public_node
    return super(TrezorClientBase, self).get_public_node(address_n)
  File "/usr/lib/python2.7/site-packages/trezorlib/client.py", line 144, in wrapped_f
    ret = f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/trezorlib/client.py", line 521, in get_public_node
    return self.call(proto.GetPublicKey(address_n=n, ecdsa_curve_name=ecdsa_curve_name, show_display=show_display, coin_name=coin_name))
  File "/usr/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 344, in init
    setattr(self, field_name, field_value)
  File "/usr/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 471, in field_setter
    self._fields[field] = type_checker.CheckValue(new_value)
  File "/usr/lib/python2.7/site-packages/google/protobuf/internal/type_checkers.py", line 155, in CheckValue
    raise TypeError(message)
TypeError: None has type <type 'NoneType'>, but expected one of: (<type 'str'>, <type 'unicode'>)

I got this error when I tried to pay with firmware version 1.4.0:

"sni-qt/11398" WARN 12:51:51.237 void StatusNotifierItemFactory::connectToSnw() Invalid interface to SNW_SERVICE Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/electrum_gui/qt/util.py", line 582, in run result = task.task() File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/plugin.py", line 141, in get_client client = devmgr.client_for_keystore(self, handler, keystore, force_pair) File "/usr/lib/python2.7/site-packages/electrum/plugins.py", line 397, in client_for_keystore client = self.force_pair_xpub(plugin, handler, info, xpub, derivation, devices) File "/usr/lib/python2.7/site-packages/electrum/plugins.py", line 427, in force_pair_xpub client_xpub = client.get_xpub(derivation) File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/clientbase.py", line 153, in get_xpub node = self.get_public_node(address_n, creating).node File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/clientbase.py", line 221, in wrapped return func(self, *args, kwargs) File "/usr/lib/python2.7/site-packages/electrum_plugins/trezor/clientbase.py", line 198, in get_public_node return super(TrezorClientBase, self).get_public_node(address_n) File "/usr/lib/python2.7/site-packages/trezorlib/client.py", line 144, in wrapped_f ret = f(*args, kwargs) File "/usr/lib/python2.7/site-packages/trezorlib/client.py", line 521, in get_public_node return self.call(proto.GetPublicKey(address_n=n, ecdsa_curve_name=ecdsa_curve_name, show_display=show_display, coin_name=coin_name)) File "/usr/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 344, in init setattr(self, field_name, field_value) File "/usr/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 471, in field_setter self._fields[field] = type_checker.CheckValue(new_value) File "/usr/lib/python2.7/site-packages/google/protobuf/internal/type_checkers.py", line 155, in CheckValue raise TypeError(message) TypeError: None has type <type 'NoneType'>, but expected one of: (<type 'str'>, <type 'unicode'>)

This update has been unpushed.