Comments
hhorak
It works for postgresql container as I'd expect
It seems to do what it should :) (tested on s2i-python container)
Looks good
Providing karma based on the tests passing (seen above).
Tests passed fine:
Testing 'docker run' usage...
Testing 'cgroup limits' usage...
The test is running as root, all tests for cgroup limits will be run
Testing 'limited memory' usage...
MEMORY_LIMIT_IN_BYTES=536870912
Testing 'NUMBER_OF_CORES' value...
NUMBER_OF_CORES=8
Testing 'NUMBER_OF_CORES' value with --cpuset-cpus=0...
NUMBER_OF_CORES=1
Testing 'NO_MEMORY_LIMIT' value...
NO_MEMORY_LIMIT=true
Testing 'MEMORY_LIMIT_IN_BYTES' value...
MEMORY_LIMIT_IN_BYTES=9223372036854775807
Tests for 'candidate-registry.fedoraproject.org/f35/s2i-core:0-54.container' succeeded.
A new build uses freshly built s2i-core with after GA packages.
Tested locally, moving further because it is required for other images to build on top of it.
Thanks for the feedback, I'll submit a newer update once s2i-core update is marked final (can't do it before).
Works good in my scenario.
The update looks good to me.
Works in my local simple tests.
LGTM, simply workflow works.
fedpkg switch-branch does not work for me: https://bugzilla.redhat.com/show_bug.cgi?id=1484062
Works in tests from https://github.com/devexp-db/db-ci-tests/blob/master/packages/mariadb
Works in tests from https://github.com/devexp-db/db-ci-tests/blob/master/packages/mariadb
Works in tests from https://github.com/devexp-db/db-ci-tests/blob/master/packages/community-mysql
Works in tests from https://github.com/devexp-db/db-ci-tests/blob/master/packages/community-mysql
Works in my simple use case.
Works fine in my simple scenarios.
Works fine