Fixed the typo, thanks!

Bug is fixed, thanks!

@mgrabovs, please submit this for stable ASAP, thanks!

Seems to reliably crash during execution of "bomb-workers" in the browserbench.org/JetStream benchmark.

I don't think it's severe enough to block this update, but feel free to report a bug on WebKit Bugzilla. Thanks for testing!

This cannot be tested until it goes stable, so fake +1 karma to facilitate testing.

Thanks!

I'll switch it to Recommends in the next update anyway. Just be careful if you don't install weak deps. ;)

Sorry, https://bugzilla.redhat.com/show_bug.cgi?id=1816442 was not the same bug I thought it was. Better link is https://github.com/flatpak/flatpak/issues/2861. Note that although WebKit does not use flatpak itself, its sandbox is very similar to flatpak and depends on both xdg-desktop-portal and xdg-desktop-portal-gtk.

I'll discuss the dependency with other maintainers and see what they think should be done.

OK, it seems the settings portal is designed to utilize multiple portal backends at once. E.g. if you have both xdg-desktop-portal-gtk and xdg-desktop-portal-kde installed, you'll get both GTK and Qt settings. So it's expected to have multiple portal backends running at the same time.

The design is not perfect, though, because this is very confusing. Users running Qt apps in GNOME might miss Qt settings (or KDE settings?) without xdg-desktop-portal-kde installed, and users running GTK apps in KDE might miss GTK settings without xdg-desktop-portal-gtk installed. The design is also confusing and non-parallel in that one backend corresponds to a desktop environment (KDE) while the other corresponds to a graphical toolkit (GTK). So a rethink is certainly in order. But this is what we have today.

So this one dependency leads to a long chain of unnecessary packages, which webkit2gtk3 managed fine without previously despite having needing it since 2.26.0. Do i really need flatpak-selinux and flatpak-session-helper? Especially if I exclude the weak dependencies.

Problem is that if you don't have xdg-destkop-portal-gtk, then, for example, you won't have antialiased fonts in sandboxed applications. If your fonts don't look like total crap with that package missing, that means the application is unsandboxed and unsafe. See, for example, https://bugzilla.redhat.com/show_bug.cgi?id=1816442. Also, many other functions that depend on host portals will not work, e.g. printing, notifications, etc.

I can change it from Requires to Recommends in the next update if you want; however, that will result in seriously degraded functionality. So with that all in mind, do you want me to make that change? I assume that users who choose not to install Recommends should be OK with having some features not work properly (but I suspect that's not always the case :)

I'll discuss the dependency with other maintainers and see what they think should be done.

So I can change the dependency to only require xdg-desktop-portal, but this means that the web process won't be able to see GTK-related settings, e.g. your host font configuration. Those are not exposed by xdg-desktop-portal, only by xdg-desktop-portal-gtk. (I'm kinda tired of bug reports about broken font settings.) I guess I can change it to Recommends though, so you can uninstall it if you really want to, on the understanding that you're going to have degraded behavior if it's missing.

I don't know about flatpak-session-helper, but understanding that WebKit isn't going to work properly without xdg-desktop-portal-gtk, and that xdg-desktop-portal-gtk requires flatpak-session-helper, I'd guess it's probably important. :)

It depends on xdg-desktop-portal-gtk (it is WebKitGTK, after all :) and actually has since 2.26.0, but until now the dependency was missing from the spec file.

We should fix this in F31 as well.

Yeah, seems my build failed on i386 and I didn't notice. Surprised bodhi doesn't have any safety guards to prevent this.

F32 was finalized several days ago, sorry. Will have to be a post-release update.