Comments
c72578
Just a minor comment, for the next version of the spec file, concerning the changelog:
Wed Aug 10 2017 -> Thu Aug 10 2017
Works for me.
Used for requesting branch:
https://pagure.io/releng/fedora-scm-requests/issue/13
Works for me
Works for me
Works for me
Works for me
A fix for this has been released upstream:
Fix DrawRoundedRectangle assert with wxGTK 3.0
Commit: https://github.com/vslavik/poedit/commit/86e0677f48a309314b45ba5f06c1c62d14b2200d
A patch file created from this commit can be found here:
https://raw.githubusercontent.com/c72578/rpmbuild/master/SOURCES/poedit-2.0.2_fix_drawroundedrectangle_assert.patch
Packages of Poedit 2.0.2 including this patch have been built in the following copr repo for testing:
https://copr.fedorainfracloud.org/coprs/c72578/poedit/
Remark : These copr builds include Crowdin integration and CLD2 language detection
The package has been built using "compat-openssl10-devel" (1:1.0.2j-6.fc26).
Was this intentional?
See root.log: https://kojipkgs.fedoraproject.org//packages/websocketpp/0.7.0/5.fc26/data/logs/noarch/root.log
This is due to the "BuildRequires: pkgconfig(openssl)" in the spec file. However, "BuildRequires: openssl-devel" would build against the newer openssl 1.1.
Thanks. Works for me.
And when building websocketpp-0.7.0-4.fc26 with openssl-devel the following error occurs now (coming from websocketpp-0.7.0-openssl11.patch) instead of the previous one:
/builddir/build/BUILD/websocketpp-0.7.0/test/transport/asio/security.cpp:65:6: required from here
/builddir/build/BUILD/websocketpp-0.7.0/websocketpp/transport/asio/security/tls.hpp:363:39: error: could not convert 'boost::asio::ssl::error::make_error_code((boost::asio::ssl::error::stream_errors)1)' from 'boost::system::error_code' to 'std::error_code'
return make_error_code(boost::asio::ssl::error::stream_truncated);
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In the test package websocketpp-0.7.0-4.fc26, the following is missing in the spec file:
BuildRequires: openssl-devel
The patch "websocketpp-0.7.0-openssl11.patch" does not show an immediate effect, when openssl is not enabled.
See the related build log, which shows, that OPENSSL is missing:
https://kojipkgs.fedoraproject.org//packages/websocketpp/0.7.0/4.fc26/data/logs/noarch/build.log
-- OPENSSL_FOUND = FALSE
-- OPENSSL_INCLUDE_DIR = OPENSSL_INCLUDE_DIR-NOTFOUND
-- OPENSSL_LIBRARIES = OPENSSL_SSL_LIBRARY-NOTFOUND;OPENSSL_CRYPTO_LIBRARY-NOTFOUND
-- OPENSSL_VERSION =
The following error appears now instead, when compiling cpprest 2.9.1:
/usr/include/websocketpp/transport/asio/security/tls.hpp:363:39: error: could not convert 'boost::asio::ssl::error::make_error_code((boost::asio::ssl::error::stream_errors)1)' from 'boost::system::error_code' to 'std::error_code'
return make_error_code(boost::asio::ssl::error::stream_truncated);
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [src/CMakeFiles/cpprest.dir/build.make:690: src/CMakeFiles/cpprest.dir/websockets/client /ws_client_wspp.cpp.o] Error 1
Upstream issue report: https://github.com/vslavik/poedit/issues/396
Same problem observed with poedit-2.0.2-1.fc26 as reported by png2378. Remark: This problem does not appear with the previous poedit-2.0.1-1.fc26.x86_64.rpm for testing.
Some comments on the poedit.spec file of poedit-2.0.2-1:
-
This requirement should be added:
BuildRequires: json-devel
Reason: Use json.hpp from Fedora and not the version of json.hpp bundled with Poedit
See also: https://github.com/vslavik/poedit/commit/0d77ff59ec4e2007a0e4e96e3126045843788ccf -
Not required any more in Poedit >= 2.0.0:
BuildRequires: libdb-cxx-devel -
Not required any more for Poedit >= 2.0.0:
rm -f %{buildroot}%{_datadir}/icons/hicolor//mimetypes/text-x-gettext-translation. -
Not available any more in Poedit >= 2.0.0:
%{_libexecdir}/poedit-dump-legacy-tm
Some comments concerning the spec file:
Not required any more in Poedit >= 2.0.0
BuildRequires: libdb-cxx-devel
Not available any more in Poedit >= 2.0.0
rm -f %{buildroot}%{_datadir}/icons/hicolor//mimetypes/text-x-gettext-translation.
Not available any more in Poedit >= 2.0.0
%{_libexecdir}/poedit-dump-legacy-tm
Remark: In the meantime Poedit 2.0.2 has been released.
Works for me. Tested with Poedit 2.0.2.
Works for me
Thanks, works fine.
Tested this package by building vkmark under Fedora 25:
Native dependency glm found: YES 0.9.7