works

This fixes all the six text crashers for me. 🎉 (#1573152 is still there, but it's unrelated.)

Sorry about the large text in previous comment, I was not trying to emphasize those two bugs. It is only because I wrote "#1612618" which was interpreted as a markdown heading.

Great! #1577125, #1580211, #1608371 and #1657329 are the same bug and now work properly for me, with the cursor going correctly to the end of the line if required.

1612618 and #1665402 seem to be the same bug, and are still not fixed.

I think #1573152 is unrelated.

s/_characters.size()/_parent_layout->_characters.size()/
s/_glyphs.size()/_parent_layout->_glyphs.size()/

Hmm, yes, #1612618 still crashes, so I tried it in gdb. This is half-guessing (i.e. untested): in src/libnrtype/Layout-TNG-OutIter.cpp, there is the function

bool Layout::iterator::nextLineCursor(int n) {
    // ...
    _char_index = _parent_layout->_cursorXOnLineToIterator(line_index + n, _x_coordinate)._char_index;
    _glyph_index = _parent_layout->_characters[_char_index].in_glyph;
    return true;
}

_char_index can actaully be _characters.size(), so I think it could be fixed by changing the last lines to:

bool Layout::iterator::nextLineCursor(int n) {
    // ...
    _char_index = _parent_layout->_cursorXOnLineToIterator(line_index + n, _x_coordinate)._char_index;
    if (_char_index == _characters.size())
        _glyph_index = _glyphs.size();
    else
        _glyph_index = _parent_layout->_characters[_char_index].in_glyph;
    return true;
}

(Sorry if this is not the right place to post tentative patches.)

https://launchpadlibrarian.net/405852336/inkscape-0.92.3-oob.patch

--- src/libnrtype/Layout-TNG-OutIter.cpp.orig   2019-01-11 19:56:12.701209914 +0100
+++ src/libnrtype/Layout-TNG-OutIter.cpp    2019-01-11 19:58:19.624114664 +0100
@@ -46,7 +46,8 @@
             best_x_difference = this_x_difference;
         }
     }
-    if (best_char_index == -1) return iterator(this, char_index);
+    if (best_char_index == -1) best_char_index = char_index;
+    if (best_char_index == _characters.size()) return end();
     return iterator(this, best_char_index);
 }

fixes my textbox crashes

fixes my textbox crashes

I'll get back to you on Monday.

I appreciate the effort to update yubioath-desktop to the latest upstream release but this update breaks the core functionality for me on my Yubikey NEO with Fedora 29

I had to downgrade to 4.3.3 again to access my TOTPs

Create a folder with names like ' BU'$'\223''7V' after every restart and/or login in my homefolder.

It does not crash, but now clicking after the last character or between the last two characters will place the cursor before the last two characters. I submitted an (untested) alternative patch on the upstream bug, maybe it helps?

dnf install https://kojipkgs.fedoraproject.org//packages/yubioath-desktop/4.3.5/3.gitd1187b6.fc29/x86_64/yubioath-desktop-4.3.5-3.gitd1187b6.fc29.x86_64.rpm

Working on my F29 x64.

dnf install https://kojipkgs.fedoraproject.org//packages/yubikey-manager/2.0.0/3.gite17b3de.fc29/noarch/yubikey-manager-2.0.0-3.gite17b3de.fc29.noarch.rpm https://kojipkgs.fedoraproject.org//packages/yubikey-manager/2.0.0/3.gite17b3de.fc29/noarch/python3-yubikey-manager-2.0.0-3.gite17b3de.fc29.noarch.rpm

working on my F29 x64 , thx

hello sgallagh, thank you for your efforts! does this update only fix CVE-2018-12120 and not the other vulnerabilities from release v6.15.0? https://nodejs.org/en/blog/release/v6.15.0/

thank you, sascha

yep working fine for me

https://bugzilla.redhat.com/show_bug.cgi?id=1657972

Thanks jpena it fixed the issue. Also dmsimard said to me a new release of osc-lib should be done tomorrow.