Comments

11 Comments
karma

I tested the update on a Fedora 31 container used for Windows builds of Godot Engine.

Our project led to the report of the binutils bug https://sourceware.org/bugzilla/show_bug.cgi?id=24267, and I can confirm that Godot's current master branch compiled with LTO and -static crashes with mingw-binutils-2.32-5.fc31 and works fine with mingw-binutils-2.32-6.fc1 (this update candidate).

(Cf. https://github.com/godotengine/godot/issues/24641 for anyone interested in steps to reproduce for BZ#1475237 on a big codebase.)

BZ#1475237 Bad compilation of small program if LTO is used
BZ#1740709 Backport the CVE patches applied to its native counter part

For the reference, this update fixed https://bugzilla.redhat.com/show_bug.cgi?id=1646888 too.

karma

Too late to give my -1, but this update is broken in the same way that 18.2.3 is. See https://bodhi.fedoraproject.org/updates/FEDORA-2018-bcdb732491

I had a user test 18.2.2, 18.2.3 and 18.2.4 for https://bugzilla.redhat.com/show_bug.cgi?id=1646888 and they confirm that both 18.2.3 and 18.2.4 are broken (18.2.2 was fine).

Any chance to revert this update? It's also breaking Godot: https://bugzilla.redhat.com/show_bug.cgi?id=1646888

I tested the update candidate and found two issues, I will fix them in a new build: - missing dependency: libmodplug. Apparently it's not a hard dependency of SDL2_mixer, so it needs to be required explicitly for the music to work - missing dependency: pygtk2-libglade. I assumed it was part of pygtk2, but it's a separate package which is not a dependency of the former

User Icon akien commented & provided feedback on lugaru-1.2-1.el7 5 years ago

I reviewed the spec file changes and backported patches, they are all good: http://pkgs.fedoraproject.org/cgit/rpms/lugaru.git/log/

I've tested Lugaru 1.2 built on both Fedora 25 and Mageia 6 with a similar process, and it does not seem to introduce any regression compared to version 1.1.

I did not test the EPEL7 package myself, though.

BZ#1421396 lugaru-1.2 is available
User Icon akien commented & provided feedback on lugaru-1.2-1.fc24 5 years ago

I reviewed the spec file changes and backported patches, they are all good: http://pkgs.fedoraproject.org/cgit/rpms/lugaru.git/log/

I've tested Lugaru 1.2 built on both Fedora 25 and Mageia 6 with a similar process, and it does not seem to introduce any regression compared to version 1.1.

I did not test the FC24 package myself, though.

BZ#1421396 lugaru-1.2 is available
User Icon akien commented & provided feedback on lugaru-1.2-1.fc25 5 years ago

I reviewed the spec file changes and backported patches, they are all good: http://pkgs.fedoraproject.org/cgit/rpms/lugaru.git/log/

I've tested Lugaru 1.2 built on both Fedora 25 and Mageia 6 with a similar process, and it does not seem to introduce any regression compared to version 1.1.

I did not test the FC25 package myself, though.

BZ#1421396 lugaru-1.2 is available

I could not test the F24 package specifically, but I've successfully tested the same SRPM on F25 (see FEDORA-2016-fe4313378f) and Mageia Cauldron, whose mingw toolchain is based off F24's IINM.

BZ#1396748 Review Request: mingw-openal-soft - MinGW port of Open Audio Library

Have testing this package from Neal Gompa's copr for Lugaru CI builds on then-rawhide (now F25), the package worked great.

I've also submitted that same package to Mageia Cauldron, and used it locally successfully with a similar mingw setup as F25's (both mingw32 and mingw64).

BZ#1396748 Review Request: mingw-openal-soft - MinGW port of Open Audio Library