Comments

357 Comments
karma

no regressions noted

karma

works

Found the bug for which I am responsible for.

Current code is assuming the user pass the option --mock-config. If none is specified the mock command in deps.py fails. I sent a PR upstream but in the meantime, as a workaround, pass the --mock-config option to fedora-review (all your reviews should be done on fedora Rawhide so --mock-config fedora-rawhide-x86_64).

-1 karma for now while we fix the thingie.

PR: https://pagure.io/FedoraReview/pull-request/347 Bug: https://pagure.io/FedoraReview/issue/346

Looking at the automated test output:

 {
               "arch" : "noarch",
               "code" : "DesktopIconFileMissing",
               "context" : {
                  "excerpt" : [
                     "Icon=scantailor"
                  ],
                  "lineno" : 6,
                  "path" : "/usr/share/fedora-review/test/desktop-file/scantailor.desktop"
               },
               "diag" : "Icon file <var>scantailor</var> not found",
               "subpackage" : "fedora-review-tests"
            },
            {
               "arch" : "noarch",
               "code" : "DesktopFileValidation",
               "context" : {
                  "path" : "/usr/share/fedora-review/test/scantailor.desktop"
               },
               "diag" : "hint: value item \"ImageProcessing\" in key \"Categories\" in group \"Desktop Entry\" can be extended with another category among the following categories: Education, or Science",
               "subpackage" : "fedora-review-tests"
            },

Is this a problem?

I have got the same error as @ankursinha on F29:

03-18 13:38 root         DEBUG        CheckRpmlintInstalled completed: 55.724 seconds
03-18 13:38 root         DEBUG    Running check: CheckRpmlintDebuginfo
03-18 13:38 root         DEBUG    Run command: rpmlint -f /tmp/tmp1yshmfv5 /home/jstanek/redhat/fedora-review/review-mako/results/mako-debuginfo-1.2-1.fc30.x86_64.rpm
03-18 13:38 root         DEBUG        CheckRpmlintDebuginfo completed: 1.120 seconds
03-18 13:38 root         DEBUG    Running check: CheckInitDeps
03-18 13:38 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 239, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 229, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 118, in _run_checks
    writedown=not Settings.no_report)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 378, in run_checks
    run_check(name)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 352, in run_check
    check.run()
  File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py", line 358, in run
    deps.init()
  File "/usr/lib/python3.7/site-packages/FedoraReview/deps.py", line 36, in init
    'dnf'])
  File "/usr/lib64/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/lib64/python3.7/subprocess.py", line 472, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib64/python3.7/subprocess.py", line 1453, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType
03-18 13:38 root         ERROR    Exception down the road...(logs in /home/jstanek/.cache/fedora-review.log)
03-18 13:38 root         DEBUG    Report completed:  207.555 seconds

CLI: $ fedora-review --name=mako with mako.spec and mako-1.2-1.fc31.src.rpm from #1689634

Got an error here:

Finish: run

03-18 10:39 root         DEBUG        CheckRpmlintInstalled completed: 46.150 seconds
03-18 10:39 root         DEBUG    Running check: CheckRpmlintDebuginfo
03-18 10:39 root         DEBUG        CheckRpmlintDebuginfo completed: 0.002 seconds
03-18 10:39 root         DEBUG    Running check: CheckInitDeps
03-18 10:39 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 239, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 229, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 118, in _run_checks
    writedown=not Settings.no_report)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 378, in run_checks
    run_check(name)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 352, in run_check
    check.run()
  File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py", line 358, in run
    deps.init()
  File "/usr/lib/python3.7/site-packages/FedoraReview/deps.py", line 36, in init
    'dnf'])
  File "/usr/lib64/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/lib64/python3.7/subprocess.py", line 472, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib64/python3.7/subprocess.py", line 1453, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType
03-18 10:39 root         ERROR    Exception down the road...(logs in /home/asinha/.cache/fedora-review.log)
03-18 10:39 root         DEBUG    Report completed:  500.607 seconds

The command-line was: $ fedora-review -b 1649059

$ fedora-review -V
fedora-review version 0.7.0 dfc9dd8 2019-03-17 14:56:47 -0400
external plugins:

Unsure if this is a fedora-review bug, so not giving -1 just yet.

karma

works for me

Works great! LGTM! =)

karma

Submitting builds with fedpkg continues to work fine.

karma

my system don't have python2 stuff and this update did not bring it :)

User Icon orion commented & provided feedback on koji-1.17.0-5.el7 a year ago
karma

It appears that the problem was an old ~/.koji/serverca.crt file that apparently was previously being ignored but now is not. I'm not sure if that is expected behavior or not. Removing the file allows it to work.

@orion - What commands were you running? What does koji --debug hello say?

Auth works for me (in an el7 container).

[root@cae219cab1ce /]# rpm -q koji
koji-1.17.0-5.el7.noarch
[root@cae219cab1ce /]# koji hello
g'day, mikem!

You are using the hub at https://koji.fedoraproject.org/kojihub
Authenticated via GSSAPI
User Icon orion commented & provided feedback on koji-1.17.0-5.el7 a year ago
karma

Kerberos authentication fails: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:618) Could not execute build: Could not login to https://koji.fedoraproject.org/kojihub

downgrade fixed it.

karma

Works great! LGTM! =)

karma

Works

BZ#1485517 btrfs-progs-4.20.2 is available
Test Case Mount btrfs
karma

Works

karma

Works

karma

works for me